Re: [DIYbio] Request for Feedback: PySplicer 0.2

On Wed, Apr 24, 2013 at 7:26 AM, Cathal Garvey wrote:
> I'm emailing this all here to ask for feedback; PySplicer was written
> for my own use, and I'm planning to put it to use ASAP. But if anyone

Complaints:

* No tests. That should be fixed, especially if you plan on your work
being verifiable multiple months into the future. I believe biopython
has a good test suite that you can go look at (and if not, just use
python-requests' tests as a gold standard).

* AGPL. No thanks.. too many problems with that license.

* You have a hash-bang in setup.py, but nobody ever marks their
setup.py as executable so I'm not sure why you would do that..

* easy_install is usually easy_install and not easy-install

* There's a bunch of lowercase class names.. should you want to be
really truly pedantic, then use pylint or pyflakes. Ultimate pedantry
achieved.

- Bryan
http://heybryan.org/
1 512 203 0507

--
-- You received this message because you are subscribed to the Google Groups DIYbio group. To post to this group, send email to diybio@googlegroups.com. To unsubscribe from this group, send email to diybio+unsubscribe@googlegroups.com. For more options, visit this group at https://groups.google.com/d/forum/diybio?hl=en
Learn more at www.diybio.org
---
You received this message because you are subscribed to the Google Groups "DIYbio" group.
To unsubscribe from this group and stop receiving emails from it, send an email to diybio+unsubscribe@googlegroups.com.
To post to this group, send email to diybio@googlegroups.com.
Visit this group at http://groups.google.com/group/diybio?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.